Fix to return early

Author: long-long-float

compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs

@@ -2692,6 +2692,11 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
             return false;
         }
 
+        if expr.span.in_derive_expansion() {
+            // Ignore if span is from derive macro.
+            return false;
+        }
+
         let Ok(src) = self.tcx.sess.source_map().span_to_snippet(expr.span) else {
             return false;
         };
@@ -2896,12 +2901,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     (None, _) | (_, None) => (true, true),
                     _ => (false, false),
                 };
-                if !expr.span.in_derive_expansion() {
-                    suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
-                    true
-                } else {
-                    false
-                }
+                suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
+                true
             }
             (ty::Uint(exp), ty::Uint(found)) => {
                 let (f2e_is_fallible, e2f_is_fallible) = match (exp.bit_width(), found.bit_width())
@@ -2913,12 +2914,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                     (None, _) | (_, None) => (true, true),
                     _ => (false, false),
                 };
-                if !expr.span.in_derive_expansion() {
-                    suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
-                    true
-                } else {
-                    false
-                }
+                suggest_to_change_suffix_or_into(err, f2e_is_fallible, e2f_is_fallible);
+                true
             }
             (&ty::Int(exp), &ty::Uint(found)) => {
                 let (f2e_is_fallible, e2f_is_fallible) = match (exp.bit_width(), found.bit_width())