Skip to content

Commit 1bcd606

Browse files
committed
llvm, rt: build using the Ninja generator if available
The Ninja generator generally builds much faster than make. It may also be used on Windows to have a vast speed improvement over the Visual Studio generators. Currently hidden behind an `--enable-ninja` flag because it does not obey the top-level `-j` or `-l` flags given to `make`.
1 parent 2ad5ed0 commit 1bcd606

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

configure

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -612,6 +612,7 @@ opt rustbuild 0 "use the rust and cargo based build system"
612612
opt orbit 0 "get MIR where it belongs - everywhere; most importantly, in orbit"
613613
opt codegen-tests 1 "run the src/test/codegen tests"
614614
opt option-checking 1 "complain about unrecognized options in this configure script"
615+
opt ninja 0 "build LLVM using the Ninja generator (for MSVC, requires building in the correct environment)"
615616

616617
# Optimization and debugging options. These may be overridden by the release channel, etc.
617618
opt_nosave optimize 1 "build optimized rust code"
@@ -775,6 +776,17 @@ probe CFG_BISON bison
775776
probe CFG_GDB gdb
776777
probe CFG_LLDB lldb
777778

779+
if [ -n "$CFG_ENABLE_NINJA" ]
780+
then
781+
probe CFG_NINJA ninja
782+
if [ -z "$CFG_NINJA" ]
783+
then
784+
# On Debian and Fedora, the `ninja` binary is an IRC bot, so the build tool was
785+
# renamed. Handle this case.
786+
probe CFG_NINJA ninja-build
787+
fi
788+
fi
789+
778790
# For building LLVM
779791
probe_need CFG_CMAKE cmake
780792

@@ -1524,7 +1536,10 @@ do
15241536
fi
15251537

15261538
# We need the generator later on for compiler-rt even if LLVM's not built
1527-
if [ ${is_msvc} -ne 0 ]
1539+
if [ -n "$CFG_NINJA" ]
1540+
then
1541+
generator="Ninja"
1542+
elif [ ${is_msvc} -ne 0 ]
15281543
then
15291544
case "$CFG_MSVC_ROOT" in
15301545
*14.0*)

mk/llvm.mk

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,21 @@ $$(LLVM_CONFIG_$(1)): $$(LLVM_DONE_$(1))
4343

4444
$$(LLVM_DONE_$(1)): $$(LLVM_DEPS_TARGET_$(1)) $$(LLVM_STAMP_$(1))
4545
@$$(call E, cmake: llvm)
46-
ifeq ($$(findstring msvc,$(1)),msvc)
46+
ifneq ($$(CFG_NINJA),)
47+
$$(Q)$$(CFG_NINJA) -C $$(CFG_LLVM_BUILD_DIR_$(1))
48+
else ifeq ($$(findstring msvc,$(1)),msvc)
4749
$$(Q)$$(CFG_CMAKE) --build $$(CFG_LLVM_BUILD_DIR_$(1)) \
4850
--config $$(LLVM_BUILD_CONFIG_MODE)
4951
else
5052
$$(Q)$$(MAKE) -C $$(CFG_LLVM_BUILD_DIR_$(1))
5153
endif
5254
$$(Q)touch $$@
5355

54-
ifeq ($$(findstring msvc,$(1)),msvc)
56+
ifneq ($$(CFG_NINJA),)
57+
clean-llvm$(1):
58+
@$$(call E, clean: llvm)
59+
$$(Q)$$(CFG_NINJA) -C $$(CFG_LLVM_BUILD_DIR_$(1)) -t clean
60+
else ifeq ($$(findstring msvc,$(1)),msvc)
5561
clean-llvm$(1):
5662
else
5763
clean-llvm$(1):

src/bootstrap/config.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,7 @@ impl Config {
317317
("OPTIMIZE_TESTS", self.rust_optimize_tests),
318318
("DEBUGINFO_TESTS", self.rust_debuginfo_tests),
319319
("LOCAL_REBUILD", self.local_rebuild),
320+
("NINJA", self.ninja),
320321
}
321322

322323
match key {

0 commit comments

Comments
 (0)