fix a bug; then prevent reintroduction of similar bugs #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Note that this pull request may need a tweak depending on whether #78 goes in first. |
|
This one will require some changes given recent pulls. |
|
I definitely agree with the ideas here. @tromey if you rebase/fix this, I'd like to merge it. |
tromey
force-pushed
the
fix-byte-compiler-add-lexbind
branch
from
89def67 to
f6b20f7
Compare
Emacs 24 introduces lexical binding, which should be preferred for new code. This enables it for rust-mode. The code continues to work fine on pre-24 Emacs, and it won't be difficult for this to remain true. One concrete advantage of lexical binding is that it lets the byte-compiler generate better warnings in some cases; here it found a couple of unused variables.
tromey
force-pushed
the
fix-byte-compiler-add-lexbind
branch
from
f6b20f7 to
866df37
Compare
|
@MicahChalmer - I've updated the branch. |
MicahChalmer
added a commit
that referenced
this pull request
Aug 23, 2015
add lexical binding and have tests check for byte compiler warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series starts by fixing a bug I found. An unbound variable was referenced.
Then it proceeds to make such bugs harder to introduce, by requiring a clean byte-compile; and then by using lexbind to get even better checking from the compiler.