Skip to content

Revert PR #22 #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

pnkfelix
Copy link
Member

@pnkfelix pnkfelix commented Feb 6, 2015

Revert "Add a hook so that we briefly highlight the matching < when > is typed."

This reverts commit 55e7483.

Undoing PR #22 since it broke emacs23 support.

… `>` is typed."

This reverts commit 55e7483.

Undoing PR rust-lang#22 since it broke emacs23 support.
@rust-highfive
Copy link

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Member Author

pnkfelix commented Feb 6, 2015

Travis build failure is here: https://travis-ci.org/rust-lang/rust-mode/jobs/49740311

@nikomatsakis
Copy link
Contributor

@MicahChalmer any tips on how we can fix emacs23 instead?

@nikomatsakis
Copy link
Contributor

@MicahChalmer also...why do we care about emacs23? I guess some non-trivial number of people still use it?

@nikomatsakis
Copy link
Contributor

@MicahChalmer final ping :) any tips on how to get a working install of emacs23 that can run unit tests? I get errors about ert not being installed.

@pnkfelix
Copy link
Member Author

pnkfelix commented Feb 6, 2015

(lets just disable emacs23 tests for the short term)

@pnkfelix pnkfelix closed this Feb 6, 2015
@MicahChalmer
Copy link
Contributor

Yipes...unfortunately I was not available during the day to get to this that quickly!

ERT was a standalone package through emacs 23, but was then made part of emacs for emacs 24. In the travis config, I have it download it from https://raw.githubusercontent.com/ohler/ert/c619b56c5bc6a866e33787489545b87d79973205/lisp/emacs-lisp/ert.el (that URL is still present in the .travis.yml here, but the use of it in the build has been disabled by #26. Grab it and put it in a place where emacs will know where to find it (the site-lisp directory where it's installed, for instance) and the tests will run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants