Fix #151 #153
Fix #151 #153
Conversation
When looking for a `where` in `rust-rewind-to-beginning-of-current-level-expr`, check that it is not part of a string or comment.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Even with this patch, there are still places in the code that look for where clauses and don't check for comments, so there are still edge cases in which the word "where" in a comment can affect the indentation. For instance, with or without this PR, rust-mode will indent the following code as follows: fn foo<F,G>(f:F, g:G)
where F:Send,
// where
G:Sized
{
}but if you change the "where" in the comment to another word, the fn foo<F,G>(f:F, g:G)
where F:Send,
// where F:ThisIsNotActualCode,
G:Sized
{
} |
|
You're right. I'll update all places where we're looking for |
Always check whether we're not in a string or comment when looking for the `where` keyword. Use two helpers for this: `rust-looking-at-where` and `rust-rewind-to-where`.
When looking for a
whereinrust-rewind-to-beginning-of-current-level-expr, check that it is notpart of a string or comment.