ert has two failures out-of-box on OS X, GNU Emacs 24.3.92.1

[pnkfelix]

To reproduce: Grab Emacs.app from http://emacsformacosx.com/

% /Applications/Emacs.app/Contents/MacOS/Emacs -batch -l rust-mode.el -l rust-mode-tests.el -f ert-run-tests-batch-and-exit
Warning: arch-dependent data dir `/Users/build/workspace/Emacs-Multi-Build/label/mavericks/emacs-source/nextstep/Emacs.app/Contents/MacOS/libexec/': No such file or directory
Running 63 tests (2015-02-06 00:47:59+0100)
Test auto-fill-multi-line-doc-comment backtrace:
  (if (unwind-protect (setq value-72102 (apply fn-72100 args-72101)) (
  (let (form-description-72104) (if (unwind-protect (setq value-72102 
  (let ((value-72102 (quote ert-form-evaluation-aborted-72103))) (let 
  (let ((fn-72100 (function rust-compare-code-after-manip)) (args-7210
  (progn (rust-mode) (insert original) (goto-char point-pos) (funcall 
  (unwind-protect (progn (rust-mode) (insert original) (goto-char poin
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b
  rust-test-manip-code("/**\n *\n */" 8 (lambda nil (unwind-protect (p
  test-auto-fill("/**\n *\n */" 8 "This is a very very very very very 
  (lambda nil (test-auto-fill "/**\n *\n */" 8 "This is a very very ve
  #[0 "\306\307!r\211q\210\310\311\312\313\314\315!\316\"\317\320%DC
  funcall(#[0 "\306\307!r\211q\210\310\311\312\313\314\315!\316\"\31
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  #[0 "r\304 q\210\305 )\306\307\310\311\312\313!\314\"\315\316%DC\2
  funcall(#[0 "r\304 q\210\305 )\306\307\310\311\312\313!\314\"\315\
  ert-run-test([cl-struct-ert-test auto-fill-multi-line-doc-comment ni
  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test a
  ert-run-tests(t #[385 "\306\307\"\203D\211\211G\310U\203\211@\20
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "rust-mode.el" "-l" "rust-mode-tests.el" "-f" "
  command-line()
  normal-top-level()
Test auto-fill-multi-line-doc-comment condition:
    (ert-test-failed
     ((should
       (rust-compare-code-after-manip original point-pos manip-func expected
                      (buffer-string)))
      :form
      (rust-compare-code-after-manip "/**\n *\n */" 8
                     (lambda nil
                       (unwind-protect ... ...))
                     "/**\n * This is a very very very very\n * very very very long string\n */" "/**\n *\nThis is a very very very very\nvery very very long string */")
      :value nil :explanation
      ("Rust code was manipulated wrong after:"
       (insert "/**\n *\n */")
       (goto-char 8)
       expected
       (insert "/**\n * This is a very very very very\n * very very very long string\n */")
       got
       (insert "/**\n *\nThis is a very very very very\nvery very very long string */")
       (first-difference-at
    (goto-char 7)
    expected " " got "\n"))))
   FAILED   1/63  auto-fill-multi-line-doc-comment
   passed   2/63  auto-fill-multi-line-prefixless
   passed   3/63  auto-fill-single-line-doc-comment
   passed   4/63  fill-paragraph-multi-line-style-inner-doc-comment
   passed   5/63  fill-paragraph-multi-paragraph-multi-line-style-doc-comment
   passed   6/63  fill-paragraph-multi-paragraph-single-line-style-doc-comment
   passed   7/63  fill-paragraph-multi-paragraph-single-line-style-indented
   passed   8/63  fill-paragraph-prefixless-multi-line-doc-comment
   passed   9/63  fill-paragraph-single-line-style-code-before-and-after
   passed  10/63  fill-paragraph-single-line-style-inner-doc-comment
   passed  11/63  fill-paragraph-single-line-style-with-code-after
   passed  12/63  fill-paragraph-single-line-style-with-code-before
   passed  13/63  fill-paragraph-top-level-multi-line-style-doc-comment-first-line
   passed  14/63  fill-paragraph-top-level-multi-line-style-doc-comment-second-line
   passed  15/63  fill-paragraph-with-no-space-after-star-prefix
   passed  16/63  font-lock-attribute-around-comment
   passed  17/63  font-lock-attribute-inner
   passed  18/63  font-lock-attribute-inside-comment
   passed  19/63  font-lock-attribute-inside-string
   passed  20/63  font-lock-attribute-key-value
   passed  21/63  font-lock-attribute-simple
Indenting region...
Indenting region...done
   passed  22/63  indent-curly-braces-within-parens
Indenting region...
Indenting region...done
Test indent-doc-comments backtrace:
  (if (unwind-protect (setq value-72102 (apply fn-72100 args-72101)) (
  (let (form-description-72104) (if (unwind-protect (setq value-72102 
  (let ((value-72102 (quote ert-form-evaluation-aborted-72103))) (let 
  (let ((fn-72100 (function rust-compare-code-after-manip)) (args-7210
  (progn (rust-mode) (insert original) (goto-char point-pos) (funcall 
  (unwind-protect (progn (rust-mode) (insert original) (goto-char poin
  (save-current-buffer (set-buffer temp-buffer) (unwind-protect (progn
  (let ((temp-buffer (generate-new-buffer " *temp*"))) (save-current-b
  rust-test-manip-code("      \n      /**\n      * This is a doc comme
  (let ((deindented (replace-regexp-in-string "^[[:blank:]]*" "      "
  test-indent("\n/**\n * This is a doc comment\n *\n */\n\n/// So is t
  (lambda nil (test-indent "\n/**\n * This is a doc comment\n *\n */\n
  #[0 "\306\307!r\211q\210\310\311\312\313\314\315!\316\"\317\320%DC
  funcall(#[0 "\306\307!r\211q\210\310\311\312\313\314\315!\316\"\31
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  #[0 "r\304 q\210\305 )\306\307\310\311\312\313!\314\"\315\316%DC\2
  funcall(#[0 "r\304 q\210\305 )\306\307\310\311\312\313!\314\"\315\
  ert-run-test([cl-struct-ert-test indent-doc-comments nil (lambda nil
  ert-run-or-rerun-test([cl-struct-ert--stats t [[cl-struct-ert-test a
  ert-run-tests(t #[385 "\306\307\"\203D\211\211G\310U\203\211@\20
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit()
  command-line-1(("-l" "rust-mode.el" "-l" "rust-mode-tests.el" "-f" "
  command-line()
  normal-top-level()
Test indent-doc-comments condition:
    (ert-test-failed
     ((should
       (rust-compare-code-after-manip original point-pos manip-func expected
                      (buffer-string)))
      :form
      (rust-compare-code-after-manip "      \n      /**\n      * This is a doc comment\n      *\n      */\n      \n      /// So is this\n      \n      fn foo() {\n      /*!\n      * this is a nested doc comment\n      */\n      \n      //! And so is this\n      }" 1
                     (lambda nil
                       (indent-region 1 ...))
                     "\n/**\n * This is a doc comment\n *\n */\n\n/// So is this\n\nfn foo() {\n    /*!\n     * this is a nested doc comment\n     */\n\n    //! And so is this\n}" "\n/**\n * This is a doc comment\n *\n */\n\n/// So is this\n\nfn foo() {\n    /*!\n     * this is a nested doc comment\n     */\n    \n    //! And so is this\n}")
      :value nil :explanation
      ("Rust code was manipulated wrong after:"
       (insert "      \n      /**\n      * This is a doc comment\n      *\n      */\n      \n      /// So is this\n      \n      fn foo() {\n      /*!\n      * this is a nested doc comment\n      */\n      \n      //! And so is this\n      }")
       (goto-char 1)
       expected
       (insert "\n/**\n * This is a doc comment\n *\n */\n\n/// So is this\n\nfn foo() {\n    /*!\n     * this is a nested doc comment\n     */\n\n    //! And so is this\n}")
       got
       (insert "\n/**\n * This is a doc comment\n *\n */\n\n/// So is this\n\nfn foo() {\n    /*!\n     * this is a nested doc comment\n     */\n    \n    //! And so is this\n}")
       (first-difference-at
    (goto-char 118)
    expected "\n" got " "))))
   FAILED  23/63  indent-doc-comments
Indenting region...
Indenting region...done
   passed  24/63  indent-indented-match
Indenting region...
Indenting region...done
   passed  25/63  indent-inside-braces
Mark set
Mark set
   passed  26/63  indent-line-after-whitespace-motion
Mark set
Mark set
   passed  27/63  indent-line-blank-line-indented-already-bol
Mark set
Mark set
   passed  28/63  indent-line-blank-line-indented-already-middle
Mark set
Mark set
   passed  29/63  indent-line-blank-line-motion
Mark set
Mark set
   passed  30/63  indent-line-closing-brace-motion
Mark set
Mark set
   passed  31/63  indent-line-middle-pull-motion
Mark set
Mark set
   passed  32/63  indent-line-middle-push-motion
Mark set
Mark set
   passed  33/63  indent-line-nonblank-line-indented-already-bol
Mark set
Mark set
   passed  34/63  indent-line-nonblank-line-indented-already-middle
Indenting region...
Indenting region...done
   passed  35/63  indent-match
Indenting region...
Indenting region...done
   passed  36/63  indent-match-multiline-pattern
Indenting region...
Indenting region...done
   passed  37/63  indent-multi-line-attrib
Indenting region...
Indenting region...done
   passed  38/63  indent-multi-line-expr
Indenting region...
Indenting region...done
   passed  39/63  indent-nested-fns
Indenting region...
Indenting region...done
   passed  40/63  indent-nonmatch-or-expression
Indenting region...
Indenting region...done
   passed  41/63  indent-params-align
Indenting region...
Indenting region...done
   passed  42/63  indent-params-no-align
Indenting region...
Indenting region...done
   passed  43/63  indent-square-bracket-alignment
Indenting region...
Indenting region...done
   passed  44/63  indent-struct-fields-aligned
Indenting region...
Indenting region...done
   passed  45/63  indent-top-level
   passed  46/63  indent-weirdly-indented-block
Mark set
Mark set
   passed  47/63  rust-beginning-of-defun-before-open-brace
Mark set
Mark set
   passed  48/63  rust-beginning-of-defun-between-fns
Mark set
Mark set
   passed  49/63  rust-beginning-of-defun-from-end
Mark set
Mark set
   passed  50/63  rust-beginning-of-defun-from-middle-of-fn
Mark set
Mark set
   passed  51/63  rust-beginning-of-defun-pub-fn
Mark set
Mark set
   passed  52/63  rust-beginning-of-defun-with-arg
Mark set
Mark set
   passed  53/63  rust-beginning-of-defun-with-negative-arg
Mark set
Mark set
   passed  54/63  rust-end-of-defun-before-open-brace
Mark set
Mark set
   passed  55/63  rust-end-of-defun-between-fns
Mark set
Mark set
   passed  56/63  rust-end-of-defun-from-beg
Mark set
Mark set
   passed  57/63  rust-end-of-defun-from-middle-of-fn
Mark set
Mark set
   passed  58/63  rust-end-of-defun-with-arg
Mark set
Mark set
   passed  59/63  rust-end-of-defun-with-negative-arg
Mark set
Mark set
Mark set
Mark set
Mark set
   passed  60/63  rust-mark-defun-from-end
Mark set
Mark set
Mark set
Mark set
Mark set
   passed  61/63  rust-mark-defun-from-middle-of-fn
Mark set
Mark set
Mark set
Mark set
Mark set
   passed  62/63  rust-mark-defun-from-middle-of-struct
Mark set
Mark set
Mark set
Mark set
Mark set
   passed  63/63  rust-mark-defun-start-of-defun

Ran 63 tests, 61 results as expected, 2 unexpected (2015-02-06 00:48:01+0100)

2 unexpected results:
   FAILED  auto-fill-multi-line-doc-comment
   FAILED  indent-doc-comments

(I don't know if this is Mac-specific or Emacs-version specific or what. I will hopefully check against a Linux VM in the near future.)

[pnkfelix]

ah, @MicahChalmer it appears you already have a fix for this in your repo; do you mind if I put it in?

[pnkfelix]

@MicahChalmer ah in fact it seems like that commit is already a part of the other PR you wanted me to review; I will just land it separately now.

[MicahChalmer]

Please do...in fact the same commit is part of two different PRs I have open (since I didn't want to submit either of them with the tests still failing.) Now at least that one won't be redundantly included in both.