Skip to content

Use visit_expr_field for ParamPosition #9458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

Alexendoo
Copy link
Member

A small change to make it a little simpler

changelog: none

@rust-highfive
Copy link

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 10, 2022
@giraffate
Copy link
Contributor

@bors r+

It looks good, thanks!

@bors
Copy link
Contributor

bors commented Sep 12, 2022

📌 Commit 1b245e7 has been approved by giraffate

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 12, 2022

⌛ Testing commit 1b245e7 with merge 018b54b...

@bors
Copy link
Contributor

bors commented Sep 12, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 018b54b to master...

@bors bors merged commit 018b54b into rust-lang:master Sep 12, 2022
@nyurik
Copy link
Contributor

nyurik commented Sep 12, 2022

I think this PR broke format parsing. To test, add this to tests/ui/explicit_write.rs (e.g. around line 39) -- before this PR, it would suggest a replacement with eprintln!("{:w$}", val, w = width);, but now it fails to parse and silently ignores.

        let val = 1;
        let width = 2;
        writeln!(std::io::stderr(), "{:w$}", val, w = width).unwrap();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants