Add --type flag to dev new_lint
#9182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Serial-ATA
force-pushed
the
new_lint-type-flag
branch
from
e772081 to
dde41b5
Compare
xFrednet
reviewed
Jul 21, 2022
|
☔ The latest upstream changes (presumably #9130) made this pull request unmergeable. Please resolve the merge conflicts. |
Serial-ATA
force-pushed
the
new_lint-type-flag
branch
from
dde41b5 to
51cd5a8
Compare
xFrednet
reviewed
Jul 26, 2022
xFrednet
approved these changes
Jul 27, 2022
|
I suggest rephrasing one paragraph in the documentation. Otherwise, everything looks good to me. If you agree with the change, you can commit it and merge it with Thank you for this addition, it was something I wanted to see for a longer time! @bors delegate+ |
|
✌️ @Serial-ATA can now approve this pull request |
Serial-ATA
force-pushed
the
new_lint-type-flag
branch
from
179b81f to
8319196
Compare
|
@bors r=xFrednet |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
This only works with directories,
--type={copies, doc, ...}won't work. Should they be counted?