Collect renamed lints

[Serial-ATA]

changelog: Display past names of renamed lints on Clippy's lint list

cc #7172

r? @xFrednet

[xFrednet]

Have you thought about how we want to display the renamed lint name on the website?

I was considering something like this:

Or maybe

(Though I like the first option more)

In either case, we can prepare do some work in our metadata collector to make the website faster. That's why I'm asking 🙃

---

r? @dswij You might want to wait until we're resolved the presentation part. You're welcome to also share your ideas 🙃

[Serial-ATA]

I had a similar idea to the first one, except it was "Past names" instead of "Notes". Since it'll show up in search regardless, I don't think making a new entry to point to the rename is necessary. 🙂

[xFrednet]

I had a similar idea to the first one, except it was "Past names" instead of "Notes". Since it'll show up in search regardless, I don't think making a new entry to point to the rename is necessary.

Past names is a better name. In that case, I would already add this to the documentation in rust, similar to how it's done for configurations. 🙃

[dswij]

Was just thinking if Notes can even include recent changelogs to the lint, but that's probably too much noise

What happens when we rename a lint twice? Would Past Names have all past lint names?

[Serial-ATA]

I updated it to account for multiple renames 🙂.

[xFrednet]

Nice, this still leaves the question where these will be rendered. I'm still for adding it to the lint description like it's done for the configuration 🙃

[Serial-ATA]

Yeah, I think it should go under the configuration as a bulleted list.

[xFrednet]

What I meant with my question of where this will be rendered was, where in our tech-stack. So if this will append the section in the metadata collector (Like the configuration section) or on the website. Where possible, I usually prefer adding it during the collection in rust, since any logic on Clippy's lint list is multiplied by the number of lints and delays the rendering. That's also why I'm mentioning this here and not in the related frontend PR since, we can implement this without touching the frontend. 🙃

Sorry, if that was unclear 😅

[Serial-ATA]

Oh 😄. In that case, yeah it should definitely be added like the configuration. I'll get that done soon.

[Serial-ATA]

Here's how it looks:

[xFrednet]

The example looks good IMO 👍

[flip1995]

The Past Names option also was my first thought when seeing this PR in my notifications 👍

[xFrednet]

I'm stealing this review back. I hope that's alright with you @dswij

r? @xFrednet

---

I should get to this during the weekend 🙃

[dswij]

Sure, go ahead!

[xFrednet]

Excellent work! I've also tested it locally and everything works perfectly. Thank you very much for this update. I'm happy to see the metadata collection project to make progress and with your work probably also be completed! ❤️ This was my first big project in Clippy, and it's also the one that held me here and introduced me to the team. I hope you also had fun with it.

Now enough rambling:

@bors r+

[bors]

📌 Commit 45be175 has been approved by xFrednet

[bors]

⌛ Testing commit 45be175 with merge c7893da...

[xFrednet]

@bors r-

[xFrednet]

Sorry for the r-, this is worth a changelog entry. I don't want this to slip under the radar of who ever will write it for that version. I've added the entry and also ticked of the checkbox in the tracking issue

@bors r+

[bors]

📌 Commit 45be175 has been approved by xFrednet

[bors]

⌛ Testing commit 45be175 with merge 8ef4908...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 8ef4908 to master...