Skip to content

Pass through extra args in cargo dev lint #8793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

Alexendoo
Copy link
Member

changelog: Pass through extra args in cargo dev lint

Lets you pass some useful flags through, like -A/W/etc, --fix, --force-warn

@rust-highfive
Copy link

r? @xFrednet

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 6, 2022
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one small comment, and then I'm happy to r+ this 🙃

@Alexendoo Alexendoo force-pushed the dev-lint-extra-args branch from e50656d to 905a951 Compare May 6, 2022 14:39
@xFrednet
Copy link
Member

xFrednet commented May 6, 2022

LGTM, thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 6, 2022

📌 Commit 905a951 has been approved by xFrednet

@bors
Copy link
Contributor

bors commented May 6, 2022

⌛ Testing commit 905a951 with merge 43756b6...

@bors
Copy link
Contributor

bors commented May 6, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 43756b6 to master...

@bors bors merged commit 43756b6 into rust-lang:master May 6, 2022
@Alexendoo Alexendoo deleted the dev-lint-extra-args branch May 6, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants