Tweak common tool docs on type-implement-trait check #7583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @xFrednet |
dswij
force-pushed
the
match-trait-docs
branch
from
c961665 to
1414eaf
Compare
xFrednet
reviewed
Aug 18, 2021
dswij
force-pushed
the
match-trait-docs
branch
from
1414eaf to
1acdb49
Compare
xFrednet
reviewed
Aug 24, 2021
Common tool documentation uses `match_trait_method` which is deprecated. Additionally, adds information on why `is_trait_method` is not the preferred way.
dswij
force-pushed
the
match-trait-docs
branch
from
1acdb49 to
86e92c0
Compare
xFrednet
reviewed
Aug 26, 2021
Add missing import `paths` for the doc example. Co-authored-by: Fridtjof Stoldt <[email protected]>
|
Awesome, thank you! @bors r+ |
|
📌 Commit f0cb8a7 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7562 (comment).
changelog: none