Refactor: organize loops file into loops module (Delegated) #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #6822) made this pull request unmergeable. Please resolve the merge conflicts. |
…ck_manual_flatten
…plicit counter to explicit counter loop
…lints to each file
Y-Nak
force-pushed
the
refactor_loops_module
branch
from
730a3ce to
74bd806
Compare
|
Changes: Resolve conflicts. |
8 tasks
flip1995
reviewed
Mar 2, 2021
|
LGTM. I haven't looked in-depth on all the visitors, but I have the feeling that it might be worth looking into sharing those between the lints. Not su if that is possible though. @bors r+ Thanks for the initial work @nahuakang and thanks for picking it up @Y-Nak ! |
|
📌 Commit 19c886b has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flip1995 @nahuakang
closes #6693
r? @flip1995
As we talked about in the PM of Zulip, this PR is a delegated PR from @nahuakang.
Changes from the last commit of #6693:
check_for_loop_arg, that was pointed out here and herechangelog: Refactor
loops.rsfile intoloopsmodule.