Skip to content

Ensure Copy exception in trait definition for `wrong_self_conventio… #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2021

Conversation

ThibsG
Copy link
Contributor

@ThibsG ThibsG commented Dec 30, 2020

Add a test case to ensure Copy exception is preserved also in trait definition, when passing self by value.

Follow up of #6316

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 30, 2020
@ThibsG
Copy link
Contributor Author

ThibsG commented Dec 30, 2020

r? @ebroto as he was assigned for the related PR

@rust-highfive rust-highfive assigned ebroto and unassigned flip1995 Dec 30, 2020
@ebroto
Copy link
Member

ebroto commented Jan 2, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Jan 2, 2021

📌 Commit af480a6 has been approved by ebroto

@bors
Copy link
Contributor

bors commented Jan 2, 2021

⌛ Testing commit af480a6 with merge a02806e...

@ebroto ebroto removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 2, 2021
@bors
Copy link
Contributor

bors commented Jan 3, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing a02806e to master...

@bors bors merged commit a02806e into rust-lang:master Jan 3, 2021
@ThibsG ThibsG deleted the CopyException branch January 3, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants