Skip to content

issue_6357 update unreachable macro usage #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Conversation

rajcspsg
Copy link

changelog: none

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 28, 2020
@flip1995
Copy link
Member

This message also appears in the lint message. Can you change that too, please?

@flip1995 flip1995 added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Nov 28, 2020
@rajcspsg rajcspsg force-pushed the issue_6357 branch 2 times, most recently from a0e75a0 to 7b40b73 Compare November 28, 2020 18:16
@flip1995
Copy link
Member

Thanks, you need to update the reference files of the tests.

@rajcspsg
Copy link
Author

@flip1995 I updated reference files. I don't know why the tests are still failing. Any idea?

@flip1995
Copy link
Member

You forgot to commit a line. FYI you can run the tests/ui/update-all-references.sh, which automatically updates the files for you.

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Nov 28, 2020

📌 Commit 76f2c10 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Nov 28, 2020

⌛ Testing commit 76f2c10 with merge bc723c5...

@bors
Copy link
Contributor

bors commented Nov 28, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing bc723c5 to master...

@bors bors merged commit bc723c5 into rust-lang:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants