-
Notifications
You must be signed in to change notification settings - Fork 1.7k
issue_6357 update unreachable macro usage #6398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @flip1995 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This message also appears in the lint message. Can you change that too, please? |
a0e75a0
to
7b40b73
Compare
Thanks, you need to update the reference files of the tests. |
@flip1995 I updated reference files. I don't know why the tests are still failing. Any idea? |
You forgot to commit a line. FYI you can run the |
@bors r+ Thanks! |
📌 Commit 76f2c10 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: none