Skip to content

Rustup #6257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2020
Merged

Rustup #6257

merged 7 commits into from
Oct 28, 2020

Conversation

giraffate
Copy link
Contributor

changelog: none

@rust-highfive
Copy link

r? @flip1995

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 28, 2020
@giraffate
Copy link
Contributor Author

Hmm, test clippy-driver seems fail. Sorry, I can't investigate immediately. If anyone can handle this soon, please close this PR.

@ebroto
Copy link
Member

ebroto commented Oct 28, 2020

@bors r+

Thanks for doing this!

I've amended the PR to deprecate the lint instead of just removing it. Otherwise users that were referring to the lint (e.g. allowing it) would get an error saying the lint did not exist. By deprecating it we change that to a more informative warning.

I will sync that change back to rustc.

@bors
Copy link
Contributor

bors commented Oct 28, 2020

📌 Commit e83e79f has been approved by ebroto

@bors
Copy link
Contributor

bors commented Oct 28, 2020

⌛ Testing commit e83e79f with merge 645ef50...

@bors
Copy link
Contributor

bors commented Oct 28, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: ebroto
Pushing 645ef50 to master...

@bors bors merged commit 645ef50 into rust-lang:master Oct 28, 2020
@giraffate giraffate deleted the sync-from-rust branch October 28, 2020 23:22
@giraffate
Copy link
Contributor Author

I've amended the PR to deprecate the lint instead of just removing it. Otherwise users that were referring to the lint (e.g. allowing it) would get an error saying the lint did not exist. By deprecating it we change that to a more informative warning.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants