Skip to content

Conversation

ghost
Copy link

@ghost ghost commented May 31, 2020

clippy_lints makes use of dep_kinds on NodeDep but this was only
added in versoin 0.9.1. Compiling with 0.9.0 will fail because of this.

changelog: none

`clippy_lints` makes use of `dep_kinds` on `NodeDep` but this was only
added in versoin 0.9.1. Compiling with 0.9.0 will fail because of this.
@rust-highfive
Copy link

r? @phansch

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 31, 2020
@ghost
Copy link
Author

ghost commented May 31, 2020

The latest version of cargo_metadata is 0.10.0. I don't know if there is any reason not to switch to that but I kept this change conservative.

@phansch
Copy link
Contributor

phansch commented May 31, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2020

📌 Commit 6122612 has been approved by phansch

@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 6122612 with merge 9d6e3d9...

bors added a commit that referenced this pull request May 31, 2020
Increase cargo_metadata version to 0.9.1

`clippy_lints` makes use of `dep_kinds` on `NodeDep` but this was only
added in versoin 0.9.1. Compiling with 0.9.0 will fail because of this.
@bors
Copy link
Contributor

bors commented May 31, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Contributor

phansch commented May 31, 2020

@bors retry

bors added a commit that referenced this pull request May 31, 2020
Increase cargo_metadata version to 0.9.1

`clippy_lints` makes use of `dep_kinds` on `NodeDep` but this was only
added in versoin 0.9.1. Compiling with 0.9.0 will fail because of this.

changelog: none
@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 6122612 with merge 84cc142...

@bors
Copy link
Contributor

bors commented May 31, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Contributor

phansch commented May 31, 2020

Hmm.. some integration tests failed with couldn't find librustc_driver, consider setting LD_LIBRARY_PATH.

@bors retry

@bors
Copy link
Contributor

bors commented May 31, 2020

⌛ Testing commit 6122612 with merge fcc3ed2...

@bors
Copy link
Contributor

bors commented May 31, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: phansch
Pushing fcc3ed2 to master...

@bors bors merged commit fcc3ed2 into rust-lang:master May 31, 2020
@flip1995
Copy link
Member

@phansch that happens if a rustc PR gets merged between the integration_build job and the integration jobs.

@ghost ghost deleted the fix-cargo_metadata-0.9 branch June 24, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants