Skip to content

Fix the bugs of manual_memcpy, simplify the suggestion and refactor it #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 2, 2020
Merged

Fix the bugs of manual_memcpy, simplify the suggestion and refactor it #5536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ad9ad6f
Don't negate resulted offsets when `offset` is subtraction by 0
rail-rain Apr 27, 2020
37261a9
Print 0 when `end` and `offset` is 0, and also simplify the suggestion
rail-rain Apr 27, 2020
75ad839
Do not trigger `manual_memcpy` for `RangeTo`
rail-rain Apr 27, 2020
c94f0f4
Remove all `ref` keyword
rail-rain Apr 27, 2020
7dd0f34
Refactor `if` to use `else` and iterator combinators
rail-rain Apr 27, 2020
3f1e51b
Rename `negate` to `sign` and make it strong types then make `art1` &str
rail-rain Apr 27, 2020
ecb472c
Use `fn` instead of closures where unnecessary
rail-rain Apr 27, 2020
aab80ee
Extract `get_fixed_offset_var`` from `fetch_cloned_fixed_offset_var`
rail-rain Apr 27, 2020
3d121d5
Extract roles getting indexes from `get_indexed_assignments`
rail-rain Apr 27, 2020
4f2617c
Separate getting offsets and getting index expressions
rail-rain Apr 27, 2020
9fc6f37
Delay getting the snippet from slices
rail-rain Apr 27, 2020
582614f
Extract building the suggestion of `manual_memcpy`
rail-rain Apr 27, 2020
be9f7c2
Merge branch 'master' into fix_manual_memcpy
rail-rain Apr 27, 2020
51585a1
Removed unused lifetimes and a needless bool
rail-rain Apr 27, 2020
461f4a3
Add missing tests
rail-rain Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading