Implement #507 #508
Implement #507 #508
Conversation
Make `used_underscore_binding` lint compatible with MacroAttributes expansions. TODO: Add a good test for this.
|
Did you check that this works with rustc-serialize? (You can add a regular test similar to mut_mut_macro that does this) Besides the test, looks good to me! |
| println!("{}", _foo); //~ ERROR used binding which is prefixed with an underscore | ||
| } | ||
|
|
||
| // TODO: This doesn't actually correctly test this. Need to find a #[derive(...)] which sets off |
There was a problem hiding this comment.
#[derive(RustcEncodable)] should work. However, you need to include rustc_serialize, which is a Crates.io crate, so it will not work directly in a compile-fail test. Instead, add a small test, similar to mut_mut_macro, directly in tests/ (which uses RustcEncodable on a non-empty struct and has #[deny(this lint)]), and a dev-dependency on rustc-serialize in Cargo.toml. The test should always pass since this lint will not trigger there.
(Ensure the test fails when you use it for an earlier clippy version)
There was a problem hiding this comment.
|
Done. I checked, and it does not compile (because of the |
|
Awesome, thanks! |
Make
used_underscore_bindinglint compatible with MacroAttributesexpansions. TODO: Add a good test for this.
Fixes #507