Skip to content

build: do not cache clippy binaries in integration tests #4752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Oct 29, 2019

We rebuild clippy anyway. So caching them is needless

% ls -lF target/debug 
total 628M
drwxr-xr-x 22 lzutao lzutao 4.0K Oct 29 04:02 build/
drwxr-xr-x  2 lzutao lzutao 144K Oct 29 04:03 deps/
drwxr-xr-x  2 lzutao lzutao 4.0K Oct 29 03:57 examples/
drwxr-xr-x 11 lzutao lzutao 4.0K Oct 29 04:03 incremental/
-rwxr-xr-x  2 lzutao lzutao 3.4M Oct 29 04:03 cargo-clippy*
-rw-r--r--  1 lzutao lzutao  11K Oct 29 03:58 cargo-clippy.d
-rwxr-xr-x  2 lzutao lzutao 313M Oct 29 04:03 clippy-driver*
-rw-r--r--  1 lzutao lzutao  11K Oct 29 03:58 clippy-driver.d
-rw-r--r--  1 lzutao lzutao  11K Oct 29 04:03 libclippy.d
-rwxr-xr-x  2 lzutao lzutao 312M Oct 29 04:03 libclippy.so*

changelog: none

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 29, 2019

📌 Commit 55c3a3b has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 29, 2019

⌛ Testing commit 55c3a3b with merge 000c3ff...

bors added a commit that referenced this pull request Oct 29, 2019
build: do not cache clippy binaries in integration tests

We rebuild clippy anyway. So caching them is needless

```console
% ls -lF target/debug
total 628M
drwxr-xr-x 22 lzutao lzutao 4.0K Oct 29 04:02 build/
drwxr-xr-x  2 lzutao lzutao 144K Oct 29 04:03 deps/
drwxr-xr-x  2 lzutao lzutao 4.0K Oct 29 03:57 examples/
drwxr-xr-x 11 lzutao lzutao 4.0K Oct 29 04:03 incremental/
-rwxr-xr-x  2 lzutao lzutao 3.4M Oct 29 04:03 cargo-clippy*
-rw-r--r--  1 lzutao lzutao  11K Oct 29 03:58 cargo-clippy.d
-rwxr-xr-x  2 lzutao lzutao 313M Oct 29 04:03 clippy-driver*
-rw-r--r--  1 lzutao lzutao  11K Oct 29 03:58 clippy-driver.d
-rw-r--r--  1 lzutao lzutao  11K Oct 29 04:03 libclippy.d
-rwxr-xr-x  2 lzutao lzutao 312M Oct 29 04:03 libclippy.so*
```

changelog: none
@bors
Copy link
Contributor

bors commented Oct 29, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 000c3ff to master...

@bors bors merged commit 55c3a3b into rust-lang:master Oct 29, 2019
@tesuji tesuji deleted the cache/uninstall-clippy branch October 29, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants