Stop using the HIR CFG #4523
Stop using the HIR CFG #4523
Conversation
|
Looks good, apart from exceeding the lines limit in |
matthewjasper
force-pushed
the
remove-cfg-usage
branch
from
77ffcab to
5e7ff6b
Compare
|
I've changed the attributes to |
|
@bors r+ |
|
📌 Commit 5e7ff6b has been approved by |
Stop using the HIR CFG This does slightly change the behavior: * Functions with unreachable code don't end up being ignored * `match` guards are counted as +1 for each guard, rather than +1 for each pattern with a guard * Or patterns don't add to the complexity
|
Thanks, @matthewjasper! |
|
💔 Test failed - checks-travis |
|
Oh sorry, I was just about to add a changelog line @matthewjasper |
|
@bors retry |
Stop using the HIR CFG * Functions with unreachable code don't end up being ignored * `match` guards are counted as +1 for each guard, rather than +1 for each pattern with a guard * Or patterns don't add to the complexity changelog: Slightly change the behavior of the `cognitive_complexity` lint
|
💔 Test failed - checks-travis |
|
@bors retry |
Stop using the HIR CFG This does slightly change the behavior: * Functions with unreachable code don't end up being ignored * `match` guards are counted as +1 for each guard, rather than +1 for each pattern with a guard * Or patterns don't add to the complexity Changelog: none
|
💔 Test failed - checks-travis |
|
s/Changelog/changelog/ |
Stop using the HIR CFG This does slightly change the behavior: * Functions with unreachable code don't end up being ignored * `match` guards are counted as +1 for each guard, rather than +1 for each pattern with a guard * Or patterns don't add to the complexity changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
This does slightly change the behavior:
matchguards are counted as +1 for each guard, rather than +1 for each pattern with a guardchangelog: none