-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[Doc] Ignore lines starting with # #4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, from just reading the code changes. Doc changes aren't checked by the CI and have to be checked by hand. I won't get to this until tomorrow though.
I'm going to give this a quick try locally now 👍 |
I only had a look at the diff of the .json output and it seems good! Attributes are still present in the examples and the lines starting with @bors r=flip1995,phansch |
📌 Commit df211ff has been approved by |
[Doc] Ignore lines starting with # Resolves #4353 changelog: none
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit df211ff has been approved by |
[Doc] Ignore lines starting with # Resolves #4353 changelog: none
💔 Test failed - status-appveyor |
Needs #4432 to be fixed first |
@bors rollup |
[Doc] Ignore lines starting with # Resolves rust-lang#4353 changelog: none
[Doc] Ignore lines starting with # Resolves rust-lang#4353 changelog: none
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit df211ff has been approved by |
[Doc] Ignore lines starting with # Resolves #4353 changelog: none
☀️ Test successful - checks-travis, status-appveyor |
Resolves #4353
changelog: none