Skip to content

[Doc] Ignore lines starting with # #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Conversation

jeremystucki
Copy link
Contributor

Resolves #4353

changelog: none

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, from just reading the code changes. Doc changes aren't checked by the CI and have to be checked by hand. I won't get to this until tomorrow though.

@flip1995 flip1995 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2019
@phansch
Copy link
Member

phansch commented Aug 22, 2019

I'm going to give this a quick try locally now 👍

@phansch
Copy link
Member

phansch commented Aug 22, 2019

I only had a look at the diff of the .json output and it seems good! Attributes are still present in the examples and the lines starting with # are excluded. Thanks!

@bors r=flip1995,phansch

@bors
Copy link
Contributor

bors commented Aug 22, 2019

📌 Commit df211ff has been approved by flip1995,phansch

@bors
Copy link
Contributor

bors commented Aug 22, 2019

⌛ Testing commit df211ff with merge 49f4f61...

bors added a commit that referenced this pull request Aug 22, 2019
[Doc] Ignore lines starting with #

Resolves #4353

changelog: none
@bors
Copy link
Contributor

bors commented Aug 22, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Aug 22, 2019

📌 Commit df211ff has been approved by flip1995,phansch

@bors
Copy link
Contributor

bors commented Aug 22, 2019

⌛ Testing commit df211ff with merge 0f8daf1...

bors added a commit that referenced this pull request Aug 22, 2019
[Doc] Ignore lines starting with #

Resolves #4353

changelog: none
@bors
Copy link
Contributor

bors commented Aug 22, 2019

💔 Test failed - status-appveyor

@phansch phansch removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2019
@phansch
Copy link
Member

phansch commented Aug 22, 2019

Needs #4432 to be fixed first

@phansch
Copy link
Member

phansch commented Aug 23, 2019

@bors rollup

phansch added a commit to phansch/rust-clippy that referenced this pull request Aug 23, 2019
[Doc] Ignore lines starting with #

Resolves rust-lang#4353

changelog: none
phansch added a commit to phansch/rust-clippy that referenced this pull request Aug 23, 2019
[Doc] Ignore lines starting with #

Resolves rust-lang#4353

changelog: none
@phansch
Copy link
Member

phansch commented Aug 23, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors
Copy link
Contributor

bors commented Aug 23, 2019

📌 Commit df211ff has been approved by phansch

@bors
Copy link
Contributor

bors commented Aug 23, 2019

⌛ Testing commit df211ff with merge 56f51b3...

bors added a commit that referenced this pull request Aug 23, 2019
[Doc] Ignore lines starting with #

Resolves #4353

changelog: none
@bors
Copy link
Contributor

bors commented Aug 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 56f51b3 to master...

@bors bors merged commit df211ff into rust-lang:master Aug 23, 2019
@jeremystucki jeremystucki deleted the export branch August 23, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc] Ignore lines starting with # in the example code
4 participants