Ensure a non-zero value is returned by clippy if compilation fails #2863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I checked how rustc does it, and this seems to be similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b45fb35 changed the behaviour of clippy to always return 0 even if compilation failed; specifically the removal of the
rustc_driver::run()call.This PR may not be the best way to fix this issue as I've not worked with
rustc_driver, but it at least logs the issue and appears to replicate the previous behaviour.I also haven't had time to create a regression test for this issue. If someone wants to point me to where such a test should live and ideally a similar test, I can look at adding that too?