Fix ICE comparing ExprRange equality
#2439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`eq_expr` on hir::utils was throwing an ICE due to an invalid LateContext being used. Due to this missusage, it was generating an ICE with the code on the following issue: rust-lang#2423
gnieto
commented
Feb 6, 2018
| } | ||
| } | ||
|
|
||
| pub struct ConstEvalLateContext<'a, 'tcx: 'a> { |
There was a problem hiding this comment.
It does not feel ok to make this public. Even that, I saw other public functions on this lint that are being used on hir_utils.
Should this be moved to the utils module?
There was a problem hiding this comment.
I think it's fine. I'm planning a big refactor anyway
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix: #2423
eq_expron hir::utils was throwing an ICE due to an invalidLateContextbeing used. I've added a method to be able to create aConstEvalLateContextwith a customTypeckTables.There was a comment on the issue pointing that it should be create also from a specific
param_env, but it seems that is not need on this specific case. I've took a look and I didn't find any way of extracting theparam_env.