relax needless_range_loop so that it reports only direct indexing
#2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add your tests to our test suite? |
|
I think I can. That's basically another pair of files under tests/ui, right? |
|
OK, figured it out. |
|
Thanks! Regression tests help a lot in preventing this issue from occurring again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relaxes
needless_range_loopso that it doesn't report cases when variable is indexed with some complex expression. Currently changes suggested by lint are not correct, and in some cases not desired. This "aggressive" check was there since PR #2021.Fixes #2106 #2036
Test code and linter outputs here:
https://gist.github.com/chyvonomys/fcdc306d38c0de7cb40764fa697be593