Skip to content

Fix verbose_bit_mask off by one error #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2017
Merged

Fix verbose_bit_mask off by one error #1953

merged 1 commit into from
Aug 14, 2017

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Aug 13, 2017

Fixes #1940

What would be preferred solution, replacing > with >= or incrementing n.count_ones()?

@mati865
Copy link
Contributor Author

mati865 commented Aug 13, 2017

Right now clippy builds only with version nightly-2017-08-09.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 13, 2017

What would be preferred solution, replacing > with >= or incrementing n.count_ones()?

I think >=. Adding one to something is always a little ugly imo

@mati865
Copy link
Contributor Author

mati865 commented Aug 13, 2017

Currently it's >= solution and tests are passing with nightly-2017-08-09.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 13, 2017

Yea, I'm working on the rustup right now: #1947

@oli-obk oli-obk merged commit 3ab06c1 into rust-lang:master Aug 14, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Aug 14, 2017

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mati865 @oli-obk