Skip to content

Fix manual_let_else FN when diverges on simple enum variant #14732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented May 4, 2025

Closes #14598

Implemented checks for simple enum variants when checking if match arms are disjointed.

changelog: [manual_let_else] fix FN when diverges on simple enum variant

@rustbot
Copy link
Collaborator

rustbot commented May 4, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 4, 2025
@rustbot

This comment has been minimized.

@profetia
Copy link
Contributor Author

profetia commented May 7, 2025

Hmm.. Why isn't this PR merged automatically?

@samueltardieu
Copy link
Contributor

The PR are never merged automatically in this repository, the assigned reviewer has to press the "Merge when ready" button.

@dswij
Copy link
Member

dswij commented May 7, 2025

Whoops yeah, I might've forgotten to click the merge button. 😅

@dswij dswij added this pull request to the merge queue May 7, 2025
@dswij dswij removed this pull request from the merge queue due to a manual request May 7, 2025
@dswij dswij added this pull request to the merge queue May 7, 2025
Merged via the queue into rust-lang:master with commit f88f9a9 May 7, 2025
11 checks passed
@nyurik
Copy link
Contributor

nyurik commented May 7, 2025

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_let_else not suggesting a fix for match statement
6 participants