Improve test coverage #1255
Merged
Improve test coverage #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash never needs to be good but before it was simply doing nothing for these.
|
This is amazing work! Will review tomorrow. |
|
We could let kcov only be run on master, fwiw. We don't care about travis cycle times on master (do we?) |
Don't think so. |
|
We could also use coveralls? |
|
If we integrate it in travis, yes. |
Manishearth
approved these changes
Oct 3, 2016
| @@ -0,0 +1,2 @@ | |||
| fn this_is_obviously(not: a, toml: file) { | |||
There was a problem hiding this comment.
Could we place this in tests/aux?
| @@ -0,0 +1 @@ | |||
| blacklisted-names = 42 | |||
| --verify \ | ||
| --include-path="$(pwd)/src","$(pwd)/clippy_lints/src" \ | ||
| "$tmpdir/$t" \ | ||
| cargo test --test "$t" |
There was a problem hiding this comment.
wonder if there's a better way of doing this. perhaps we could turn off the compiletest tests with an env var, and then just run cargo test?
|
r=me when ready |
|
Actually, looks ready now 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a script
util/cov.shto runkcovon clippy.I did not configure travis to use because it takes some time (~15min on my machine), and uses a lot of memory. Also some results are weird:
kcovdoes not seem to like rust'smatchvery much;kcovdefinitely does not like ourit_let_chain!macro (it only considers the first line, and we have a lot of those);Anyway, it did show some stuffs that we were not testing but could easily do: reported coverage goes up from 90.9% to 91.4% 🎉 🎈
For fun,^w^w here are the reports before and after.