Skip to content

Update ui_test to 0.22 #12289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update ui_test to 0.22 #12289

wants to merge 1 commit into from

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Feb 13, 2024

Blocked on oli-obk/ui_test#198.

changelog: None

@rustbot
Copy link
Collaborator

rustbot commented Feb 13, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 13, 2024
@matthiaskrgr
Copy link
Member

#12198 🤔

@Jarcho
Copy link
Contributor Author

Jarcho commented Feb 13, 2024

I thought I had seen that earlier, but a search for 'ui_test' didn't show anything. Thank you GitHub.

@flip1995
Copy link
Member

Should we close the other PR, in favor of this? I like this PR better, as it doesn't change all the $DIR replacements in the stderr files.

@Jarcho
Copy link
Contributor Author

Jarcho commented Feb 13, 2024

This will still have the same change, I just hadn't updated the tests on this yet due to the linked issue.

@bors
Copy link
Contributor

bors commented Feb 17, 2024

☔ The latest upstream changes (presumably #12198) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho closed this Feb 17, 2024
@oli-obk
Copy link
Contributor

oli-obk commented Feb 17, 2024

Thanks for fixing ui_test @Jarcho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants