fix: ICE when array index exceeds usize #12266
Conversation
|
r? @Manishearth rustbot has assigned @Manishearth. Use r? to explicitly pick a reviewer |
rustbot
added
the
S-waiting-on-review
|
@bors r+ |
y21
added
the
beta-nominated
|
It's probably unlikely that anyone is realistically gonna run into this ICE in practice outside of fuzzing, considering you need to index with an integer greater than is allowed to begin with, but the ICE made it to beta and (I think) we've historically been beta backporting ICE fixes so, nominating this one |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
flip1995
added
beta-accepted
I wouldn't create a backport PR just for this. But as there are other backports that should be done, I will just include this. It's a really small change, so nothing really speaks against backporting it. So nominating these is definitely right. 👍 |
…ulacrum [beta] Clippy backports Backports included in this PR: - rust-lang/rust-clippy#12276 Fixing the lint on some platforms before hitting stable - rust-lang/rust-clippy#12405 Respect MSRV before hitting stable - rust-lang/rust-clippy#12266 Fixing an (unlikely) ICE - rust-lang/rust-clippy#12177 Fixing FPs before hitting stable Each backport on its own might not warrant a backport, but the collection of those are nice QoL fixes for Clippy users, before those bugs hit stable. All of those commits are already on `master`. r? `@Mark-Simulacrum`
xFrednet
removed
the
beta-accepted
fixes #12253
This PR fixes ICE in
indexing_slicingas it panics when the index of the array exceedsusize.changelog: none