Extend useless_asref lint on map(clone)

[GuillaumeGomez]

If you have code like:

Some(String::new()).as_ref().map(Clone::clone)

the as_ref call is unneeded.

Interestingly enough, this lint and map_clone are starting to share a same "space" where both lints warn about different things for the same code. Not sure what's the policy about such cases though...

r? @llogiq

changelog: Extend useless_asref lint on map(clone)

[GuillaumeGomez]

And fixed dogfood failure. I forget this one every time...

[llogiq]

Not sure what's the policy about such cases though...

As long as the lints work independently of each other and don't invalidate each other's diagnostics (and especially suggestions), they can easily coexist. Otherwise (if one lint rules out the other) we must decide which one is preferable and remove those cases from the other lint.

[GuillaumeGomez]

Ok so in this case I'll limit the map_clone lint so it doesn't overlap in here.

[bors]

☔ The latest upstream changes (presumably #12109) made this pull request unmergeable. Please resolve the merge conflicts.

[llogiq]

Thank you. Stellar work, you're on a roll!

@bors r+

[bors]

📌 Commit f7ef9a6 has been approved by llogiq

It is now in the queue for this repository.

[bors]

⌛ Testing commit f7ef9a6 with merge e899684...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing e899684 to master...

[GuillaumeGomez]

Thanks for the kind words and the blazing fast reviews! 😊