[question_mark]: also trigger on return statements

[y21]

This fixes the false negative mentioned in #11993: the lint only used to check for return expressions, and not a statement containing a return expression (doesn't close the issue tho since there's still a useful suggestion that we could make, which is to suggest .ok_or()?/.ok_or_else()? for else { return Err(..) })

changelog: [question_mark]: also trigger on return statements

[rustbot]

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

[samueltardieu]

I like how it immediately flagged 3 instances in Clippy sources. I wonder how many will trigger in popular crates.

[samueltardieu]

From the top 500 crates, only 4 crates triggered this lint, totaling a number of 72 instances (most of them in the plotters-backend crate).

[y21]

Nice. This comment made me think that this would cause us to lint in a lot more cases due to rustfmt adding the semicolon and suppressing the lint that way for correctly-formatted code, but double-checking now, it doesn't seem to be case that it does that.

Hopefully those 4 are legit warnings and not FPs? Also thanks for running lintcheck, I meant to do that myself but forgot 😅

[samueltardieu]

Hopefully those 4 are legit warnings and not FPs?

Looks like it. I'm currently submitting a PR for the libc crate, and may submit others as well.

[xFrednet]

LGTM, small NIT and then we can r+ this :D

[xFrednet]

This change looks good to me. Could you also add a check for comments, with span_contains_comment and a test?

    let Some(x) = y else {
        // Roses are red,
        // violets are blue,
        // please keep this comment,
        // it's art, you know?
        return None;
    };

[y21]

Good idea! Fixed. (also love that quote)

[xFrednet]

Perfection! And what a masterpiece.

@bors r+

[bors]

📌 Commit e44caea has been approved by xFrednet

It is now in the queue for this repository.

[bors]

⌛ Testing commit e44caea with merge 830f1c5...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 830f1c5 to master...