[manual_retain]: add lint case for binary_heap
#11329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
unvalley
force-pushed
the
lint-binary-heap-retain
branch
from
d1abb75 to
428e60a
Compare
refactor: rename variable chore: reorder test: update naming for msrv
unvalley
force-pushed
the
lint-binary-heap-retain
branch
from
838bd75 to
d5dbee4
Compare
Alexendoo
reviewed
Aug 13, 2023
tests/ui/manual_retain.rs
Outdated
Comment on lines
227
to
231
| #[clippy::msrv = "1.70"] | ||
| fn _msrv_170() { | ||
| let mut binary_heap = BinaryHeap::from([1, 2, 3]); | ||
| binary_heap = binary_heap.into_iter().filter(|x| x % 2 == 0).collect(); | ||
| } |
There was a problem hiding this comment.
This should be 1.69 to test that it isn't applied when the MSRV is below BinaryHeap::retain's introduction
There was a problem hiding this comment.
Thanks, I updated it at 1eff39d
Alexendoo
approved these changes
Aug 13, 2023
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9059
This PR adds changes to perform linting on the
binary_heapas well, under the manual_retain rule.changelog: [manual_retain]: update for lint
binary_heap