make cast_possible_wrap work correctly for 16 bit {u,i}size #10564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrap, and make it work correctly for 16 bit {u,i}size
|
r? @flip1995 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
r? rust-lang/clippy It has been a couple months, and there hasn't been a review, so rerolling, unless there's another process to request a review? |
giraffate
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Overall looks good, thanks!
Can we add the note about usize and isize are at least 16-bits wide. in the reference?
#9337 (comment)
|
@bors r+ Thanks! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make
cast_possible_wrapaware of the different pointer widths and fixes the implementation to print the correct pointer widths.Fixes #9337
changelog:
cast_possible_wrapdoes not lint onu8 as isizeorusize as i8, since these can never wrap.cast_possible_wrapnow properly considers 16 bit pointer size and prints the correct bit widths.