Skip to content

Do not base map_entry lint suggestion on expanded code #10346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

samueltardieu
Copy link
Contributor

Fixes #10331

changelog: [map_entry]: do not base suggestion on code expanded by the compiler

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 14, 2023
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2023

📌 Commit e4e5924 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 14, 2023

⌛ Testing commit e4e5924 with merge 0e40f94...

@bors
Copy link
Contributor

bors commented Feb 14, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 0e40f94 to master...

@bors bors merged commit 0e40f94 into rust-lang:master Feb 14, 2023
@samueltardieu samueltardieu deleted the issue-10331 branch February 19, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect suggestion when contains_key+insert is used in a while loop
4 participants