fix manual_filter false positive #10091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do explicit checks for the other branch being None
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) soon. Please see the contribution instructions for more information. |
rustbot
added
the
S-waiting-on-review
|
Hey, thanks for the fix! Could you add a test for #9766 as I believe your fix will fix this issue too |
The related issue is rust-lang#9766 where the `manual_filter` lint would remove side effects
|
Thanks @kraktus, I wasn't aware that there was a related issue. That's great that this fix also resolves the other issue! |
ericwu17
force-pushed
the
manual-filter-FP
branch
from
62cd8d9 to
3c14075
Compare
|
I hope that won't disturb the history, but I have faith in our bot. Thank you for working on this. @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10088
fixes #9766
changelog: FP: [
manual_filter]: Now ignores if expressions where the else branch has side effects or doesn't returnNone#10091