Skip to content

Lots of doc tests are not executed #4319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phansch opened this issue Aug 1, 2019 · 0 comments · Fixed by #4331
Closed

Lots of doc tests are not executed #4319

phansch opened this issue Aug 1, 2019 · 0 comments · Fixed by #4331
Assignees
@phansch

Comments

@phansch
Copy link
Member

phansch commented Aug 1, 2019

From #4307 (comment)

If I understand the declare_clippy_lint macro correctly, doc tests are only executed for style and correctness lints. The other lint groups are missing the $(#[$attr])* in front. Adding the missing ones resulted in 137 failing doc tests.
@phansch phansch self-assigned this Aug 1, 2019
phansch added a commit to phansch/rust-clippy that referenced this issue Aug 2, 2019
@phansch
Doctests: Fix all complexity lint docs
dc43389 
cc rust-lang#4319
@phansch phansch mentioned this issue Aug 2, 2019
Merged
phansch added a commit to phansch/rust-clippy that referenced this issue Aug 2, 2019
@phansch
Doctests: Fix all complexity lint docs
abfa8a9 
cc rust-lang#4319
bors added a commit that referenced this issue Aug 2, 2019
@bors
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
7185ad5 
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
phansch added a commit to phansch/rust-clippy that referenced this issue Aug 3, 2019
@phansch
Doctests: Enable running doc tests for perf lints
c0cdfd2 
This should be possible to merge independently of rust-lang#4325

cc rust-lang#4319
@phansch phansch mentioned this issue Aug 3, 2019
Merged
bors added a commit that referenced this issue Aug 3, 2019
@bors
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
12d215e 
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
bors added a commit that referenced this issue Aug 3, 2019
@bors
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
3dc9183 
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
bors added a commit that referenced this issue Aug 3, 2019
@bors
Auto merge of #4327 - phansch:doctests_perf, r=flip1995
5c1e30a 
Doctests: Enable running doc tests for perf lints

changelog: none

This should be possible to merge independently of #4325

cc #4319
This was referenced Aug 3, 2019
Merged
Merged
Merged
flip1995 added a commit to flip1995/rust-clippy that referenced this issue Aug 5, 2019
@flip1995
Rollup merge of rust-lang#4329 - phansch:doctests_pedantic, r=flip1995
713ad96 
Doctests: Enable running doc tests for pedantic lints

changelog: none

master: 202 passed; 0 failed; 122 ignored; 0 measured; 0 filtered out
this PR: 254 passed; 0 failed; 131 ignored; 0 measured; 0 filtered out

cc rust-lang#4319
flip1995 added a commit to flip1995/rust-clippy that referenced this issue Aug 5, 2019
@flip1995
Rollup merge of rust-lang#4330 - phansch:doctests_nursery, r=flip1995
f5db24a 
Doctests: Enable running doc tests for nursery lints

changelog: none

master: 202 passed; 0 failed; 122 ignored; 0 measured; 0 filtered out
this PR: 213 passed; 0 failed; 122 ignored; 0 measured; 0 filtered out

cc rust-lang#4319
flip1995 added a commit to flip1995/rust-clippy that referenced this issue Aug 5, 2019
@flip1995
Rollup merge of rust-lang#4331 - phansch:doctests_restriction, r=flip…
93c3da2 
…1995

Doctests: Enable running doc tests for restriction lints

changelog: Enabled remaining doc tests for lint documentation page

master: 202 passed; 0 failed; 122 ignored; 0 measured; 0 filtered out
this PR: 231 passed; 0 failed; 123 ignored; 0 measured; 0 filtered out

Closes rust-lang#4319 (assuming this is merged after rust-lang#4329 and rust-lang#4330)
@bors bors closed this as completed in #4331 Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phansch phansch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doctests: Enable running doc tests for restriction lints phansch/rust-clippy
1 participant
@phansch