Fix incorrect suggestion for manual_unwrap_or_default

Author: GuillaumeGomez

clippy_lints/src/manual_unwrap_or_default.rs

@@ -60,6 +60,11 @@ fn get_some<'tcx>(cx: &LateContext<'tcx>, pat: &Pat<'tcx>) -> Option<HirId> {
         && (cx.tcx.lang_items().get(LangItem::OptionSome) == Some(def_id)
         || cx.tcx.lang_items().get(LangItem::ResultOk) == Some(def_id))
     {
+        if let PatKind::Tuple(elements, dotdot) = pat.kind
+            && (elements.len() > 1 || dotdot.as_opt_usize().is_some())
+        {
+            return None;
+        }
         let mut bindings = Vec::new();
         pat.each_binding(|_, id, _, _| bindings.push(id));
         if let &[id] = bindings.as_slice() {

tests/ui/manual_unwrap_or_default.fixed

@@ -78,3 +78,10 @@ fn issue_12569() {
         0
     };
 }
+
+// Should not warn!
+fn issue_12928() {
+    let x = Some((1, 2));
+    let y = if let Some((a, _)) = x { a } else { 0 };
+    let y = if let Some((a, ..)) = x { a } else { 0 };
+}

tests/ui/manual_unwrap_or_default.rs

@@ -111,3 +111,10 @@ fn issue_12569() {
         0
     };
 }
+
+// Should not warn!
+fn issue_12928() {
+    let x = Some((1, 2));
+    let y = if let Some((a, _)) = x { a } else { 0 };
+    let y = if let Some((a, ..)) = x { a } else { 0 };
+}