Skip to content

Improve typography #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2018
Merged

Improve typography #1070

merged 3 commits into from
Apr 14, 2018

Conversation

hghwng
Copy link
Contributor

@hghwng hghwng commented Apr 6, 2018

Remove ambiguous "here" in links.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@hghwng
Copy link
Contributor Author

hghwng commented Apr 6, 2018

If you think such improvement is okay, I'd like to work on all the occurrences systematically.

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you think such improvement is okay, I'd like to work on all the occurrences systematically.

sounds great, thanks! do you want to add the other occurrences to this pull request or open a new one?

@hghwng
Copy link
Contributor Author

hghwng commented Apr 9, 2018

Thanks! I'd like to simplify the process by appending more commits to this PR in the following days. I'll leave a message when it's done.

Remove ambiguous "here" in links, and update links that redirect.
@hghwng
Copy link
Contributor Author

hghwng commented Apr 11, 2018

Hi Corey, in addition to cleaning all "here" links, I also replaced old links of crates.io to the redirected URL. Is that okay?

In addition to extra binaries, there is support for benchmarks, tests, and
examples. The full capabilities are documented
[here](http://doc.crates.io/book/guide/project-layout.html).
In addition to extra binaries, `cargo` supports [more features] such as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing link to more features?

@hghwng
Copy link
Contributor Author

hghwng commented Apr 12, 2018

Sorry for the mistake — I changed the sentence at the last minute but forgot to update the link.

It's embarrassing that not only the markdown link is incorrect, the old URL is also not updated. 🙁

Copy link
Member

@marioidival marioidival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@frewsxcv frewsxcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @hghwng!

@frewsxcv frewsxcv merged commit 093765b into rust-lang:master Apr 14, 2018
@hghwng hghwng deleted the patch-1 branch April 17, 2018 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants