-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve typography #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typography #1070
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
If you think such improvement is okay, I'd like to work on all the occurrences systematically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think such improvement is okay, I'd like to work on all the occurrences systematically.
sounds great, thanks! do you want to add the other occurrences to this pull request or open a new one?
Thanks! I'd like to simplify the process by appending more commits to this PR in the following days. I'll leave a message when it's done. |
Remove ambiguous "here" in links, and update links that redirect.
Hi Corey, in addition to cleaning all "here" links, I also replaced old links of crates.io to the redirected URL. Is that okay? |
In addition to extra binaries, there is support for benchmarks, tests, and | ||
examples. The full capabilities are documented | ||
[here](http://doc.crates.io/book/guide/project-layout.html). | ||
In addition to extra binaries, `cargo` supports [more features] such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing link to more features
?
Sorry for the mistake — I changed the sentence at the last minute but forgot to update the link. It's embarrassing that not only the markdown link is incorrect, the old URL is also not updated. 🙁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @hghwng!
Remove ambiguous "here" in links.