-
Notifications
You must be signed in to change notification settings - Fork 745
Run many CI jobs in parallel #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bors-servo
merged 3 commits into
rust-lang:master
from
fitzgen:split-up-ci-into-many-jobs
Aug 11, 2017
Merged
Run many CI jobs in parallel #901
bors-servo
merged 3 commits into
rust-lang:master
from
fitzgen:split-up-ci-into-many-jobs
Aug 11, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No one intends to make this work. We should focus on new versions of libclang going forward.
Our test runner is smart enough to figure out which test expectations to use now.
Our CI is performing multiple different jobs: * For every libclang version we support: * With both debug and release profiles: * Generating bindings from our test headers, with and without extra assertions, and asserting there is no diff from the expectations. * Compiling and testing the generated bindings. * Compiling and testing the bindgen-integration crate. * Testing the md book. * Asserting that there aren't any system includes in any of the test headers. * Asserting that all the pub functions have doc comments. We were previously doing these things sequentially for each libclang version. This commit breaks these jobs up explicitly and runs each of them one at a time so that they can each be run in parallel, on different Travis CI machines.
This brought our wall clock CI time down from about 1h45m to about 45m 🎉 🎉 |
emilio
approved these changes
Aug 11, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super, thanks! r=me
@bors-servo r+ |
📌 Commit 59b8535 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 11, 2017
Run many CI jobs in parallel Our CI is performing multiple different jobs: * For every libclang version we support: * With both debug and release profiles: * Generating bindings from our test headers, with and without extra assertions, and asserting there is no diff from the expectations. * Compiling and testing the generated bindings. * Compiling and testing the bindgen-integration crate. * Testing the md book. * Asserting that there aren't any system includes in any of the test headers. * Asserting that all the pub functions have doc comments. We were previously doing these things sequentially for each libclang version. This commit breaks these jobs up explicitly and runs each of them one at a time so that they can each be run in parallel, on different Travis CI machines. r? @emilio
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI is performing multiple different jobs:
We were previously doing these things sequentially for each libclang version. This commit breaks these jobs up explicitly and runs each of them one at a time so that they can each be run in parallel, on different Travis CI machines.
r? @emilio