ir: Ignore non-finite macro constants from macros. #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
fitzgen
approved these changes
Mar 15, 2017
src/ir/var.rs
Outdated
| @@ -146,6 +146,11 @@ impl ClangSubItemParser for Var { | |||
| let (type_kind, val) = match value { | |||
| EvalResult::Invalid => return Err(ParseError::Continue), | |||
| EvalResult::Float(f) => { | |||
| // Bail out if this number is not finite. We could | |||
| // generate those, I guess, but its utility is unclear. | |||
There was a problem hiding this comment.
I guess I'd flip this question on its head: why wouldn't we want to generate bindings for them? That's kinda the business we're in ;-P
File a follow up? Maybe it would be a good first bug?
|
@bors-servo r+ Please also file that follow up issue :) |
|
📌 Commit abed16d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 15, 2017
ir: Ignore non-finite macro constants from macros. Fixes #582.
|
@bors-servo r- Yeah, I changed my mind. Also have another test case for it. |
|
ok, this should be better. r? @fitzgen |
|
@bors-servo r+ |
|
📌 Commit 22d5a8f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 15, 2017
ir: Ignore non-finite macro constants from macros. Fixes #582.
|
☀️ Test successful - status-travis |
This was referenced Mar 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582.