tests: Add an integration test for static arrays. #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fitzgen
approved these changes
Jan 29, 2017
| let also_expected = unsafe { bindings::Test_COUNTDOWN_PTR }; | ||
| assert!(!test.is_null()); | ||
| assert_eq!(also_expected, expected, "Pointer value was bogus"); | ||
| assert_eq!(test, also_expected, "Array value was bogus"); |
There was a problem hiding this comment.
Nitpick: Assertion diagnostic messages should describe expectations, not explain what happens when things go wrong. Expectations read fine whether the assertion is passing (ie when I happen to be reading this code) or when it is printed out because of assertion failure. What is written here only reads OK if the assertion is failing.
Here is my suggested wording:
bindings::Test_COUNTDOWN.as_ptr() should be the same as bindings::Test_countdown()
but in this particular case, I think the default assert_eq message should be fine.
Turns out they were broken before rust-lang#456. Let's test it so it doesn't regress.
These aren't extremely great, since this usually requires extra bookkeeping. But C allows it, so let's keep the same semantics.
|
@bors-servo r=fitzgen Thanks for the review Nick :) |
|
📌 Commit fedca48 has been approved by |
|
☀️ Test successful - status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out they were broken before
#456.
Let's test it so it doesn't regress.
r? @fitzgen