codegen: Fix typedef re-export in namespaces when bindings aren't at the root.

[emilio]

No description provided.

[emilio]

r? @fitzgen

[emilio]

Fixes #433

[fitzgen]

Can you also add this test case:

namespace JS {
class Value;
}
typedef enum JSWhyMagic {} JSWhyMagic;
namespace JS {
class Value {
public:
  void a(JSWhyMagic);
};
}

[emilio]

That's the exact test case that is in tree already (for #410)

[fitzgen]

That's the exact test case that is in tree already (for #410)

:-/

When I try and compile the bindings generated from this test case I get:

$ rustc --crate-type lib js.rs
error[E0412]: cannot find type `JSWhyMagic` in module `root::JS`
  --> js.rs:22:34
   |
22 |                            arg1: root::JS::JSWhyMagic);
   |                                  ^^^^^^^^^^^^^^^^^^^^ not found in `root::JS`
   |
   = help: possible candidate is found in another module, you can import it into scope:
             `use root::JSWhyMagic;`

error[E0412]: cannot find type `JSWhyMagic` in module `root::JS`
  --> js.rs:29:46
   |
29 |             pub unsafe fn a(&mut self, arg1: root::JS::JSWhyMagic) {
   |                                              ^^^^^^^^^^^^^^^^^^^^ not found in `root::JS`
   |
   = help: possible candidate is found in another module, you can import it into scope:
             `use root::JSWhyMagic;`

error: aborting due to 2 previous errors

[fitzgen]

I am getting this same error in the compilation of the SpiderMonkey bindings

[emilio]

In tree it happens to compile because root is at the top of the module.

[fitzgen]

Ok, I see what was going on now. Thanks!

[fitzgen]

This whole function body could be

let super_ = ctx.rust_ident_raw("super");
let root = ctx.root_module().canonical_name(ctx);
let root_ident = ctx.rust_ident(&root);

iter::once(ctx.rust_ident_raw("self"))
    .chain(iter::repeat(super_.clone()).take(root_import_depth(ctx, item)))
    .chain(iter::once(root_ident))
    .collect()

[fitzgen]

@bors-servo r+

[bors-servo]

📌 Commit d6fc044 has been approved by fitzgen

[fitzgen]

@bors-servo r-

[fitzgen]

@bors-servo r+

[bors-servo]

📌 Commit d6fc044 has been approved by fitzgen

[bors-servo]

⚡ Test exempted - status