[rfc] Use a dynamically loaded clang to do as much as we can with old clang versions, and experiment with new ones. #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? @fitzgen |
|
☔ The latest upstream changes (presumably #338) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Also, can be replaced with |
|
Awesome, thanks! :)
…On Tue, Dec 13, 2016 at 05:48:51PM -0800, Kyle Mayes wrote:
`clang-sys` 0.12.0 has been released with the runtime API stuff.
Also,
```
clang-sys = { version = "0.11.1", features = ["runtime", "gte_clang_3_6", "gte_clang_3_7", "gte_clang_3_8", "gte_clang_3_9"] }
```
can be replaced with
```
clang-sys = { version = "0.11.1", features = ["runtime", "clang_3_9"] }
```
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#335 (comment)
|
emilio
force-pushed
the
dlopen
branch
2 times, most recently
from
81f47ef to
6c565fd
Compare
|
@bors-servo try |
bors-servo
pushed a commit
that referenced
this pull request
Dec 14, 2016
[rfc] Use a dynamically loaded clang to do as much as we can with old clang versions, and experiment with new ones. It's a pity that we don't support clang 3.7 and similar for generating C bindings, when it should be straight-forward. This change should allow us to support older clang versions, and also experiment with pre-release clang APIs if needed. This depends on: KyleMayes/clang-sys#44
|
☀️ Test successful - status-travis |
|
@bors-servo r=fitzgen |
|
📌 Commit 6c565fd has been approved by |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit 6c565fd has been approved by |
… versions, and experiment with new ones. It's a pity that we don't support clang 3.7 and similar for generating C bindings, when it should be straight-forward. This should allow us to support older clang versions, and also experiment with pre-release clang APIs if needed. This depends on: KyleMayes/clang-sys#44
|
@bors-servo r=fitzgen Pushed a dummy commit to un-confuse bors. |
|
📌 Commit d934705 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Dec 14, 2016
[rfc] Use a dynamically loaded clang to do as much as we can with old clang versions, and experiment with new ones. It's a pity that we don't support clang 3.7 and similar for generating C bindings, when it should be straight-forward. This change should allow us to support older clang versions, and also experiment with pre-release clang APIs if needed. This depends on: KyleMayes/clang-sys#44
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a pity that we don't support clang 3.7 and similar for generating C
bindings, when it should be straight-forward.
This change should allow us to support older clang versions, and also
experiment with pre-release clang APIs if needed.
This depends on: KyleMayes/clang-sys#44