Skip to content

Make BindgenOptions clonable #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2022
Merged

Make BindgenOptions clonable #2285

merged 2 commits into from
Oct 3, 2022

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 26, 2022

Basically: #2263 (review)

@pvdrz pvdrz requested a review from emilio September 26, 2022 18:23
@pvdrz pvdrz mentioned this pull request Sep 26, 2022
Closed
kulp
kulp approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@kulp kulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insofar as I understand what @emilio was getting at in the #2263 review, this seems to fit the bill.

@pvdrz pvdrz merged commit 15aef5e into rust-lang:master Oct 3, 2022
@pvdrz pvdrz deleted the clone-options branch October 3, 2022 16:17
@bors-servo bors-servo mentioned this pull request Oct 3, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulp kulp kulp approved these changes

@emilio emilio Awaiting requested review from emilio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvdrz @kulp