Skip to content

Fallback: call "rustfmt" directly without which #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Fallback: call "rustfmt" directly without which #1629

merged 1 commit into from
Sep 28, 2019

Conversation

heidezomp
Copy link
Contributor

Implements #1628.

If the which-rustfmt feature isn't enabled, assume that the binary is
called "rustfmt" and that it is in the user's PATH, instead of returning
an error.

If the `which-rustfmt` feature isn't enabled, assume that the binary is
called "rustfmt" and that it is in the user's PATH, instead of returning
an error.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@emilio emilio merged commit d1ddfbb into rust-lang:master Sep 28, 2019
est31 added a commit to est31/coreaudio-sys that referenced this pull request Sep 28, 2019
The crates.io release of bindgen requires users to specify
rustfmt either through the API or through env vars.

The next release of bindgen will just use rustfmt from PATH
due to: rust-lang/rust-bindgen#1629
est31 added a commit to est31/coreaudio-sys that referenced this pull request Sep 28, 2019
The crates.io release of bindgen requires users to specify
rustfmt either through the API or through env vars.

The next release of bindgen will just use rustfmt from PATH
due to: rust-lang/rust-bindgen#1629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants