Fallback: call "rustfmt" directly without which #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the `which-rustfmt` feature isn't enabled, assume that the binary is called "rustfmt" and that it is in the user's PATH, instead of returning an error.
est31
added a commit
to est31/coreaudio-sys
that referenced
this pull request
Sep 28, 2019
The crates.io release of bindgen requires users to specify rustfmt either through the API or through env vars. The next release of bindgen will just use rustfmt from PATH due to: rust-lang/rust-bindgen#1629
est31
added a commit
to est31/coreaudio-sys
that referenced
this pull request
Sep 28, 2019
The crates.io release of bindgen requires users to specify rustfmt either through the API or through env vars. The next release of bindgen will just use rustfmt from PATH due to: rust-lang/rust-bindgen#1629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1628.
If the
which-rustfmtfeature isn't enabled, assume that the binary iscalled "rustfmt" and that it is in the user's PATH, instead of returning
an error.