Skip to content

Quote regexes in test headers #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Conversation

Lytigas
Copy link
Contributor

@Lytigas Lytigas commented Jul 30, 2018

When using test-one.sh, unquoted wildcards are expanded by the shell,
resulting in failing tests.

The issue showed itself via output similar to this:

$ ./test-one.sh constify-enum
warning: ..: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .git: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .gitattributes: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .github: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .gitignore: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .travis.yml: 'linker' input unused [-Wunused-command-line-argument], err: false
warning: .vscode: 'linker' input unused [-Wunused-command-line-argument], err: false
(
 kind = EnumDecl
 spelling = "nsCSSPropertyID"
...

which no longer shows after this patch.

When using test-one.sh, unquoted wildcards are expanded by the shell,
resulting in failing tests.
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@emilio emilio merged commit 29dad40 into rust-lang:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants