Use associated constants for rust enums when available #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jul 30, 2018
| ); | ||
| // Use associated constants for named enums | ||
| if enum_ty.name().is_some() && | ||
| ctx.options().rust_features().associated_const { |
There was a problem hiding this comment.
nit: Indentation is a bit weird here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to skip anonymous enums because the way they are exposed would make this a bigger job than I think this needs to be. Namely, they don't have a pretty-named rust enum. I'd be happy to look into it more if it's a desired feature.
With regards to test changes, there are several involving wrapping linter attributes. I upgraded to the latest nightly
rustfmttoday, so I think they should be correct.Unrelated: I also noticed there's some weird behavior in the
anon_enum_traittest. All the variants are set equal togeneric_type.