Skip to content

Track Rust target features with declaration macro #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2018
Merged

Track Rust target features with declaration macro #1348

merged 1 commit into from
Jul 11, 2018

Conversation

tmfink
Copy link
Contributor

@tmfink tmfink commented Jul 7, 2018

Eliminates the manual implementation of From<RustTarget> for
RustFeatures.

My initial implementation of "features" bothered me how this was missing.

@tmfink
Track Rust target features with declaration macro
b0a1752 
Eliminates the manual implementation of `From<RustTarget>` for
`RustFeatures`.
@emilio
Copy link
Contributor

emilio commented Jul 7, 2018

Thanks, looks pretty neat!

Travis is red but it doesn't seem your fault. Let's try to land this since there's other stuff that has landed recently.

@bors-servo r+

@bors-servo
Copy link

📌 Commit b0a1752 has been approved by emilio

@bors-servo
Copy link

⌛ Testing commit b0a1752 with merge 68c185d...

bors-servo pushed a commit that referenced this pull request Jul 7, 2018
Auto merge of #1348 - tmfink:feature-refactor, r=emilio
68c185d 
Track Rust target features with declaration macro

Eliminates the manual implementation of `From<RustTarget>` for
`RustFeatures`.

My initial implementation of "features" bothered me how this was missing.
@bors-servo
Copy link

💔 Test failed - status-travis

@tmfink
Copy link
Contributor Author

tmfink commented Jul 8, 2018

It looks like all of the BINDGEN_JOB="test" jobs failed on the rustup run nightly cargo install -f rustfmt-nightly command because rustc-ap-arena v147.0.0 uses the unstable feature raw_vec_internals without declaring the crate atribute #![feature(raw_vec_internals)].

@emilio emilio merged commit d61ab75 into rust-lang:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmfink @emilio @bors-servo @highfive