Store function linkage in the ir #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Oct 23, 2017
src/ir/function.rs
Outdated
| @@ -49,6 +49,12 @@ impl FunctionKind { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, Copy)] | |||
| pub enum Linkage { | |||
There was a problem hiding this comment.
Could you document this enum and the variants, please? Travis is complaining because of that.
src/ir/function.rs
Outdated
| @@ -69,6 +75,9 @@ pub struct Function { | |||
|
|
|||
| /// The kind of function this is. | |||
| kind: FunctionKind, | |||
|
|
|||
| // The linkage of the function. | |||
There was a problem hiding this comment.
Let's use a doc comment here too for consistency.
|
@bors-servo delegate+ |
|
✌️ @jrmuizel can now approve this pull request |
emilio
approved these changes
Oct 24, 2017
src/codegen/mod.rs
Outdated
| @@ -3127,6 +3127,13 @@ impl CodeGenerator for Function { | |||
| debug!("<Function as CodeGenerator>::codegen: item = {:?}", item); | |||
| debug_assert!(item.is_enabled_for_codegen(ctx)); | |||
|
|
|||
| // We can't currently do anything with Internal functions so just | |||
| // them. | |||
There was a problem hiding this comment.
So just avoid generating them?
Also I wonder if it looks nicer to just do self.linkage() != Linkage::Internal.
This lets us capture 'static inline' functions in the ir and filter them later down the pipeline. This is the first step on the way to handling these functions better.
|
I just addressed my previous comment too. @bors-servo r+ |
|
📌 Commit 02dc2bf has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 24, 2017
Store function linkage in the ir This lets us capture 'static inline' functions in the ir and filter them later down the pipeline. This is the first step on the way to handling these functions better.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us capture 'static inline' functions in the ir and filter them
later down the pipeline. This is the first step on the way to handling
these functions better.