Skip to content

--version no longer works without <HEADER> argument #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbeich opened this issue Nov 1, 2023 · 5 comments · Fixed by #2678 or felixonmars/archriscv-packages#3209
Closed

--version no longer works without <HEADER> argument #2677

jbeich opened this issue Nov 1, 2023 · 5 comments · Fixed by #2678 or felixonmars/archriscv-packages#3209

Comments

@jbeich
Copy link

jbeich commented Nov 1, 2023 •
edited
Loading

Regressed by #2656. Found via mesa@1cc26e8b6657 due to mesonbuild/meson@0f2f87a00347

$ bindgen --help | fgrep -A1 -- --version
  -V, --version
          Prints the version, and exits

$ bindgen --version
error: the following required arguments were not provided:
  <HEADER>

Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...

For more information, try '--help'.

$ bindgen --version /dev/null
bindgen 0.69.0

Previously,

$ bindgen --version
bindgen 0.68.1
@orhun
Copy link
Contributor

orhun commented Nov 1, 2023

Also hit this while generating shell completions:

$ bindgen --generate-shell-completions bash

error: the following required arguments were not provided:
  <HEADER>

Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...

For more information, try '--help'.

@orhun orhun mentioned this issue Nov 1, 2023
Merged
orhun added a commit to orhun/rust-bindgen that referenced this issue Nov 1, 2023
@orhun
fix(args): make header argument optional
fa9358c 
fixes rust-lang#2677
@erik-bershel erik-bershel mentioned this issue Nov 2, 2023
Closed
10 tasks
@erik-bershel
Copy link

Hey @orhun! How long it will take theoretically to fix this issue (to publish release)? We are blocked with an image generation for actions with this bug and thinking now about what to do next. To pin version of cli or to wait new release...

@orhun
Copy link
Contributor

orhun commented Nov 2, 2023

Hey @erik-bershel, I'm just an outside contributor so I'm not sure. The PR should be ready to go though.

felixonmars added a commit to felixonmars/archriscv-packages that referenced this issue Nov 2, 2023
@felixonmars
updpatch: rust-bindgen 0.69.0-1.1
afd8ba7 
Apply patch to fix rust-lang/rust-bindgen#2677
for building mesa.
@felixonmars felixonmars mentioned this issue Nov 2, 2023
Merged
felixonmars added a commit to felixonmars/archriscv-packages that referenced this issue Nov 2, 2023
@felixonmars
updpatch: rust-bindgen 0.69.0-1.1
ecd9f24 
Apply patch to fix rust-lang/rust-bindgen#2677
for building mesa.
pvdrz pushed a commit that referenced this issue Nov 2, 2023
@orhun
fix(args): make header argument optional (#2678)
d85878f 
* fix(args): make header argument optional

fixes #2677

* refactor(args): avoid using type aliases
@tshepang
Copy link
Member

tshepang commented Nov 2, 2023

@erik-bershel a fresh release is available with the issue fixed

@nutta-git nutta-git mentioned this issue Nov 3, 2023
Closed
@jbeich
Copy link
Author

jbeich commented Dec 7, 2024 •
edited
Loading

Please, reopen. Regressed again by #2984 (4d80917):

$ bindgen --version /dev/null
bindgen 0.71.0
$ bindgen --version
error: the following required arguments were not provided:
  <HEADER>

Usage: bindgen <FLAGS> <OPTIONS> <HEADER> -- <CLANG_ARGS>...

For more information, try '--help'.

@jbeich jbeich mentioned this issue Dec 7, 2024
Closed
This was referenced Dec 7, 2024
Open
Closed
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Dec 9, 2024
@ojeda @intel-lab-lkp
rust: document bindgen 0.71.0 regression
759a632 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has
been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Signed-off-by: Miguel Ojeda <[email protected]>
ojeda added a commit to Rust-for-Linux/linux that referenced this issue Jan 9, 2025
@ojeda
rust: document bindgen 0.71.0 regression
d75d932 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appared in 0.69.0 first [2] and was fixed in 0.69.1. It has
been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
ojeda added a commit to Rust-for-Linux/linux that referenced this issue Jan 9, 2025
@ojeda
rust: document bindgen 0.71.0 regression
c23d1f7 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It
has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
jannau pushed a commit to AsahiLinux/linux that referenced this issue Mar 1, 2025
@ojeda @jannau
rust: document bindgen 0.71.0 regression
acb0f2a 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It
has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
dylanmtaylor pushed a commit to dylanmtaylor/linux that referenced this issue Mar 28, 2025
@ojeda @jannau
rust: document bindgen 0.71.0 regression
de8792c 
`bindgen` 0.71.0 regressed [1] on the "`--version` requires header"
issue which appeared in 0.69.0 first [2] and was fixed in 0.69.1. It
has been fixed again in 0.71.1 [3].

Thus document it so that, when we upgrade the minimum past 0.69.0 in the
future, we do not forget that we cannot remove the workaround until we
arrive at 0.71.1 at least.

Link: rust-lang/rust-bindgen#3039 [1]
Link: rust-lang/rust-bindgen#2677 [2]
Link: https://github.com/rust-lang/rust-bindgen/blob/main/CHANGELOG.md#v0711-2024-12-09 [3]
Reviewed-by: Fiona Behrens <[email protected]>
Reviewed-by: Alice Ryhl <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Miguel Ojeda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tshepang @jbeich @orhun @erik-bershel